phet commented on code in PR #3764:
URL: https://github.com/apache/gobblin/pull/3764#discussion_r1319213873
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java:
##########
@@ -525,11 +532,19 @@ static boolean
isCustomizedProgressReportEnabled(Properties properties) {
&&
Boolean.parseBoolean(properties.getProperty(ENABLED_CUSTOMIZED_PROGRESS));
}
- static boolean isMapperFailureFatalEnabled(Properties properties) {
- return (
-
properties.containsKey(ConfigurationKeys.MR_JOB_MAPPER_FAILURE_IS_FATAL_KEY)
- &&
Boolean.parseBoolean(properties.getProperty(ConfigurationKeys.MR_JOB_MAPPER_FAILURE_IS_FATAL_KEY)))
- || ConfigurationKeys.DEFAULT_MR_JOB_MAPPER_FAILURE_IS_FATAL;
+ static boolean isBooleanPropEnabled(Properties props, String propKey,
Optional<Boolean> optDefault) {
Review Comment:
for the two configs here, there is always a default... but if there weren't
any default, that's what the `Optional.absent()` would represent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
