[
https://issues.apache.org/jira/browse/GOBBLIN-1917?focusedWorklogId=881224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881224
]
ASF GitHub Bot logged work on GOBBLIN-1917:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/23 17:45
Start Date: 21/Sep/23 17:45
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3786:
URL: https://github.com/apache/gobblin/pull/3786#issuecomment-1730032641
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3786?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3786](https://app.codecov.io/gh/apache/gobblin/pull/3786?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(244abab) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/fc73db8b3feb0fb70a6bfde983646eecaf826ef4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(fc73db8) will **decrease** coverage by `1.26%`.
> The diff coverage is `15.38%`.
> :exclamation: Current head 244abab differs from pull request most recent
head 5e139db. Consider uploading reports for the commit 5e139db to get more
accurate results
```diff
@@ Coverage Diff @@
## master #3786 +/- ##
============================================
- Coverage 47.29% 46.03% -1.26%
+ Complexity 10948 2178 -8770
============================================
Files 2152 416 -1736
Lines 85104 17965 -67139
Branches 9452 2191 -7261
============================================
- Hits 40247 8271 -31976
+ Misses 41201 8810 -32391
+ Partials 3656 884 -2772
```
| [Files
Changed](https://app.codecov.io/gh/apache/gobblin/pull/3786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...rg/apache/gobblin/cluster/GobblinHelixJobTask.java](https://app.codecov.io/gh/apache/gobblin/pull/3786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iVGFzay5qYXZh)
| `59.57% <0.00%> (-0.65%)` | :arrow_down: |
|
[.../apache/gobblin/salesforce/BulkResultIterator.java](https://app.codecov.io/gh/apache/gobblin/pull/3786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvQnVsa1Jlc3VsdEl0ZXJhdG9yLmphdmE=)
| `0.00% <0.00%> (ø)` | |
|
[...gobblin/salesforce/SalesforceHistogramService.java](https://app.codecov.io/gh/apache/gobblin/pull/3786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZUhpc3RvZ3JhbVNlcnZpY2UuamF2YQ==)
| `4.19% <0.00%> (ø)` | |
|
[...apache/gobblin/salesforce/SalesforceExtractor.java](https://app.codecov.io/gh/apache/gobblin/pull/3786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZUV4dHJhY3Rvci5qYXZh)
| `14.61% <18.42%> (-0.16%)` | :arrow_down: |
|
[...rg/apache/gobblin/salesforce/SalesforceSource.java](https://app.codecov.io/gh/apache/gobblin/pull/3786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZVNvdXJjZS5qYXZh)
| `46.41% <100.00%> (-0.26%)` | :arrow_down: |
... and [1741 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3786/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 881224)
Time Spent: 40m (was: 0.5h)
> Logging updates for Salesforce classes
> --------------------------------------
>
> Key: GOBBLIN-1917
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1917
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-salesforce
> Reporter: Gautam Kumar
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> - Updating the log messages in the Salesforce related classes.
> - In some cases, the exception was not included in the log. Adding it to make
> debugging issues easier.
> - For some cases, added more details in the logs to print the current
> progress of the tasks.
> - Minor coding style updates as well to improve code readability.
> - There are no functional changes in this PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
