[
https://issues.apache.org/jira/browse/GOBBLIN-1917?focusedWorklogId=881271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881271
]
ASF GitHub Bot logged work on GOBBLIN-1917:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/23 02:27
Start Date: 22/Sep/23 02:27
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3786:
URL: https://github.com/apache/gobblin/pull/3786#discussion_r1333814434
##########
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java:
##########
@@ -504,10 +479,7 @@ private static String buildUrl(String path,
List<NameValuePair> qparams) throws
}
private static boolean isNullPredicate(List<Predicate> predicateList) {
- if (predicateList == null || predicateList.size() == 0) {
- return true;
- }
- return false;
Review Comment:
I can't believe this was left in here, nice catch!
Issue Time Tracking
-------------------
Worklog Id: (was: 881271)
Time Spent: 1h 10m (was: 1h)
> Logging updates for Salesforce classes
> --------------------------------------
>
> Key: GOBBLIN-1917
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1917
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-salesforce
> Reporter: Gautam Kumar
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> - Updating the log messages in the Salesforce related classes.
> - In some cases, the exception was not included in the log. Adding it to make
> debugging issues easier.
> - For some cases, added more details in the logs to print the current
> progress of the tasks.
> - Minor coding style updates as well to improve code readability.
> - There are no functional changes in this PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
