gautamguptabasant commented on code in PR #3786:
URL: https://github.com/apache/gobblin/pull/3786#discussion_r1333811858
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobTask.java:
##########
@@ -219,7 +219,7 @@ public TaskResult run() {
@Override
public void cancel() {
- log.info("Cancelling planning job {} | jobTaskMetrics: {}",
this.planningJobId, this.jobTaskMetrics);
+ log.info("Cancelling planning job {} | jobTaskMetrics: {}",
this.planningJobId, this.jobTaskMetrics.getMetrics());
Review Comment:
Hmm, somehow I read this map as <String, String>. Yes, this does look a bit
tricky to log. Omitting this change for now to get the rest of it in. Will
revisit this one later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
