Will-Lo commented on code in PR #3786:
URL: https://github.com/apache/gobblin/pull/3786#discussion_r1333814434
##########
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java:
##########
@@ -504,10 +479,7 @@ private static String buildUrl(String path,
List<NameValuePair> qparams) throws
}
private static boolean isNullPredicate(List<Predicate> predicateList) {
- if (predicateList == null || predicateList.size() == 0) {
- return true;
- }
- return false;
Review Comment:
I can't believe this was left in here, nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
