[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=881991&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881991
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/23 19:48
Start Date: 26/Sep/23 19:48
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3776:
URL: https://github.com/apache/gobblin/pull/3776#discussion_r1337703384
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/NewDagManagerBoilerPlate.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration;
+
+import com.google.common.base.Optional;
+
+import lombok.AllArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+
+@WorkInProgress
+@Slf4j
+@AllArgsConstructor
+public class NewDagManagerBoilerPlate {
+ private DagTaskStream dagTaskStream;
+ private DagProcFactory dagProcFactory;
+ private DagManager.DagManagerThread [] dagManagerThreads;
+ //TODO instantiate DMT
+
+ @WorkInProgress
+ @AllArgsConstructor
+ public static class DagManagerThread implements Runnable {
+ private DagTaskStream dagTaskStream;
+ private DagProcFactory dagProcFactory;
+ @Override
+ public void run() {
+ try {
+ while (dagTaskStream.hasNext()) {
+ Optional<DagTask> dagTask = getNextTask();
+ if (dagTask.isPresent()) {
+ DagProc dagProc = dagTask.get().host(dagProcFactory);
+ dagProc.process(dagTask.get().leaseAttemptStatus);
+ //TODO: Handle cleaning up of Dags
+ cleanUpDagTask();
Review Comment:
based on the latest commit... we will have separate CleanUp DagTasks and
DagProcs handling the responsibility. The impl. will be provided in subsequent
PRs.
Issue Time Tracking
-------------------
Worklog Id: (was: 881991)
Time Spent: 6h 50m (was: 6h 40m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
