[jira] [Work logged] (GOBBLIN-1910) Refactor code to move current in-memory references to new design for REST calls: Launch, Resume and Kill

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=881995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881995
 ]

ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Sep/23 19:50
            Start Date: 26/Sep/23 19:50
    Worklog Time Spent: 10m 
      Work Description: meethngala commented on code in PR #3776:
URL: https://github.com/apache/gobblin/pull/3776#discussion_r1337705262


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -136,14 +148,26 @@ protected void processMessage(DecodeableKafkaRecord 
message) {
     // We only expect INSERT and DELETE operations done to this table. INSERTs 
correspond to any type of
     // {@link DagActionStore.FlowActionType} flow requests that have to be 
processed. DELETEs require no action.
     try {
+
       if (operation.equals("INSERT")) {
         if (dagActionType.equals(DagActionStore.FlowActionType.RESUME)) {
           log.info("Received insert dag action and about to send resume flow 
request");
           dagManager.handleResumeFlowRequest(flowGroup, 
flowName,Long.parseLong(flowExecutionId));
+          //TODO: add a flag for if condition only if multi-active is enabled
+          if(isRefactoredDagManagerEnabled) {
+            ResumeDagTask resumeDagTask = new ResumeDagTask(new 
DagManager.DagId(flowGroup, flowName, flowExecutionId));
+            dagTaskStream.resumeFlow(resumeDagTask);
+          }

Review Comment:
   refactored the code to not use `Optional`





Issue Time Tracking
-------------------

    Worklog Id:     (was: 881995)
    Time Spent: 7h 10m  (was: 7h)

> Refactor code to move current in-memory references to new design for REST 
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1910
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Meeth Gala
>            Priority: Major
>          Time Spent: 7h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)