[
https://issues.apache.org/jira/browse/GOBBLIN-1923?focusedWorklogId=883406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883406
]
ASF GitHub Bot logged work on GOBBLIN-1923:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/23 18:20
Start Date: 04/Oct/23 18:20
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3792:
URL: https://github.com/apache/gobblin/pull/3792#discussion_r1346286426
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -101,6 +101,8 @@ public class ConfigurationKeys {
public static final String DEFAULT_MULTI_ACTIVE_SCHEDULER_CONSTANTS_DB_TABLE
= "gobblin_multi_active_scheduler_constants_store";
public static final String SCHEDULER_LEASE_DETERMINATION_STORE_DB_TABLE_KEY
= MYSQL_LEASE_ARBITER_PREFIX + ".schedulerLeaseArbiter.store.db.table";
public static final String
DEFAULT_SCHEDULER_LEASE_DETERMINATION_STORE_DB_TABLE =
"gobblin_scheduler_lease_determination_store";
+ public static final String
SCHEDULER_LEASE_DETERMINATION_TABLE_RETENTION_PERIOD_MILLIS_KEY =
MYSQL_LEASE_ARBITER_PREFIX + ".retentionPeriodMillis";
+ public static final int
DEFAULT_SCHEDULER_LEASE_DETERMINATION_TABLE_RETENTION_PERIOD_MILLIS = 500000;
Review Comment:
Updating to ~ 80 hours (300,000,000 millis). I was thinking of changing the
units but we use millis for everything else so to avoid confusion between other
constants I'll stay with millis.
Issue Time Tracking
-------------------
Worklog Id: (was: 883406)
Time Spent: 1h (was: 50m)
> Add retention thread for lease arbiter table
> --------------------------------------------
>
> Key: GOBBLIN-1923
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1923
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Add retention to lease arbiter table so it does not grow unbounded. The table
> can be as large as O(number of flows) which may grow so large that
> reading/writing from this table becomes time consuming and slows down our
> throughput of obtaining and evaluating leases for launching flows.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
