[
https://issues.apache.org/jira/browse/GOBBLIN-1923?focusedWorklogId=883445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883445
]
ASF GitHub Bot logged work on GOBBLIN-1923:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/23 00:04
Start Date: 05/Oct/23 00:04
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3792:
URL: https://github.com/apache/gobblin/pull/3792#discussion_r1346603268
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiter.java:
##########
@@ -215,12 +226,41 @@ private void initializeConstantsTable() throws
IOException {
String insertConstantsStatement =
String.format(UPSERT_CONSTANTS_TABLE_STATEMENT, this.constantsTableName);
withPreparedStatement(insertConstantsStatement, insertStatement -> {
int i = 0;
- insertStatement.setInt(++i, epsilon);
- insertStatement.setInt(++i, linger);
+ insertStatement.setInt(++i, epsilonMillis);
+ insertStatement.setInt(++i, lingerMillis);
Review Comment:
nice!
Issue Time Tracking
-------------------
Worklog Id: (was: 883445)
Time Spent: 1.5h (was: 1h 20m)
> Add retention thread for lease arbiter table
> --------------------------------------------
>
> Key: GOBBLIN-1923
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1923
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Add retention to lease arbiter table so it does not grow unbounded. The table
> can be as large as O(number of flows) which may grow so large that
> reading/writing from this table becomes time consuming and slows down our
> throughput of obtaining and evaluating leases for launching flows.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
