homatthew commented on code in PR #3818:
URL: https://github.com/apache/gobblin/pull/3818#discussion_r1379714261
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GobblinBaseOrcWriter.java:
##########
@@ -259,6 +261,15 @@ public void commit()
throws IOException {
closeInternal();
super.commit();
+ if(this.validateORCDuringCommit) {
+ try {
+ OrcFile.createReader(this.outputFile, new OrcFile.ReaderOptions(conf));
+ } catch (IOException ioException) {
+ log.error("Found error when validating ORC file {} during commit
phase", this.outputFile, ioException);
+ log.error("Delete the malformed ORC file is successful: {}",
this.fs.delete(this.outputFile, false));
Review Comment:
And is there a world where this operation fails because of `Filesystem is
closed` error? Do we need to account for that edge case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
