hanghangliu commented on code in PR #3818:
URL: https://github.com/apache/gobblin/pull/3818#discussion_r1380463543
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GobblinBaseOrcWriter.java:
##########
@@ -259,6 +261,15 @@ public void commit()
throws IOException {
closeInternal();
super.commit();
+ if(this.validateORCDuringCommit) {
+ try {
+ OrcFile.createReader(this.outputFile, new OrcFile.ReaderOptions(conf));
+ } catch (IOException ioException) {
Review Comment:
yes, we should delete in case of other runtime or unchecked exception, for
the sake of robustness. Changed to generic Exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
