hanghangliu commented on code in PR #3818:
URL: https://github.com/apache/gobblin/pull/3818#discussion_r1380652984
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GobblinBaseOrcWriter.java:
##########
@@ -258,7 +261,18 @@ public void close()
public void commit()
throws IOException {
closeInternal();
+ if(this.validateORCDuringCommit) {
+ try {
+ OrcFile.createReader(this.stagingFile, new
OrcFile.ReaderOptions(conf));
+ } catch (Exception e) {
+ log.error("Found error when validating ORC file during commit phase",
e);
+ HadoopUtils.deletePath(this.fs, this.stagingFile, false);
+ log.error("Delete the malformed ORC file after close the writer: {}",
this.stagingFile);
Review Comment:
yes, it's an info as we delete the file. But we can log the message at the
ERROR level in case user disabled for info level, as this is critical
information we'd like it to speak loud.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
