hanghangliu commented on code in PR #3818:
URL: https://github.com/apache/gobblin/pull/3818#discussion_r1380466314
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GobblinBaseOrcWriter.java:
##########
@@ -259,6 +261,15 @@ public void commit()
throws IOException {
closeInternal();
super.commit();
Review Comment:
I was thinking maybe there's something wrong during moving. But given the
issue is malformed files, so the issue should already be there after writer
closed. So move the logic to after closeInternal() is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
