umustafi opened a new pull request, #3823:
URL: https://github.com/apache/gobblin/pull/3823
* makes Config object with FlowSpec mutable
* adds unit test to ensure flow compiles after updating FlowSpec
* ensure DagManager resilient to exceptions on leadership change
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1954
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
When copying a `flowSpec` to add `flowExecutionId` into its config, all
components need to be carefully duplicated to ensure compilation, serialization
and deserialization are successful. Some pieces can easily be missed so
instead, we add the property to the `Properties` object of the `FlowSpec` which
is mutable. Note that we do not update the `Config` object to avoid large GC
overhead from deleting and creating a new `Config` object. This test also
ensures that the `DagManager` thread will not silently die during leadership
changes by catching all types of `Exceptions`.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
- Updates FlowSpecTest
- Adds unit test to FlowCompilationValidationHelper to ensure the flow
compiles and produces a valid execution plan after being updated
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
