arjun4084346 commented on code in PR #3823:
URL: https://github.com/apache/gobblin/pull/3823#discussion_r1388670830
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -484,7 +484,9 @@ public synchronized void setActive(boolean active) {
log.error("Exception encountered when shutting down DagManager
threads.", e);
}
}
- } catch (IOException e) {
+ } catch (Throwable e) {
Review Comment:
1) With the current code (i.e. the left side) also, leader transition should
fail. I did not get what are we trying to achieve here.
2) Is GobblinServiceManager (the caller of this method) not printing
stacktrace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
