phet opened a new pull request, #3835:
URL: https://github.com/apache/gobblin/pull/3835

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1961
     
   "Qualify IcebergTable DatasetDescriptors (used by Iceberg-Distcp)"
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   
   The same DB name and table name are currently used in common for both the 
source-side table and the dest-side table.  Instead, these should be allowed to 
be different, so facilitate separately specifying source names and dest names.  
Nonetheless, continue, for the sake of backwards compatibility, to support the 
legacy properties that specify the current combo props (shared by both source 
AND destination).
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   enhanced existing tests
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to