phet commented on code in PR #3835:
URL: https://github.com/apache/gobblin/pull/3835#discussion_r1401423357
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -117,17 +113,17 @@ public Iterator<FileSet<CopyEntity>>
getFileSetIterator(FileSystem targetFs, Cop
return createFileSets(targetFs, configuration);
}
- /** @return unique ID for this dataset, usable as a {@link
CopyEntity}.fileset, for atomic publication grouping */
+ /** @return unique ID for dataset (based on the source-side table), usable
as a {@link CopyEntity#getFileSet}, for atomic publication grouping */
protected String getFileSetId() {
Review Comment:
the name originally arose because it's the value provided to the
`CopyableFile.Builder.fileSet` setter -
https://github.com/apache/gobblin/pull/3835/files#diff-da31b49b793e970e5d99d51f52c63d592a6b7dfd8b18d8cc988cd52a9521d478R155
does it make more sense in context, or do you still recommend to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
