umustafi commented on code in PR #3837:
URL: https://github.com/apache/gobblin/pull/3837#discussion_r1408483434
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/TimingEventUtils.java:
##########
@@ -47,6 +47,13 @@ static Map<String, String> getFlowMetadata(Config
flowConfig) {
return metadata;
}
+ /**
+ * Retrieves a flowExecutionId from flowMetadata map and returns dummy value
if one is not set
+ */
+ public static String getFlowExecutionIdFromFlowMetadata(Map<String, String>
flowMetadata) {
+ return
flowMetadata.getOrDefault(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD,
"<<no flowExecutionId>>");
+ }
Review Comment:
This class has methods relating to this map of `FlowMetadata` specifically.
It uses a different key than the normal flow group/name/execution id keys from
`ConfigurationKeys`. I'm keeping related functionality in one place here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
