phet commented on code in PR #3837:
URL: https://github.com/apache/gobblin/pull/3837#discussion_r1409758873
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -218,8 +219,10 @@ public String toString() {
private final long failedDagRetentionTime;
private final DagManagerMetrics dagManagerMetrics;
+ @Getter
@Inject(optional=true)
- protected Optional<DagActionStore> dagActionStore;
+ @VisibleForTesting
+ public Optional<DagActionStore> dagActionStore;
Review Comment:
couldn't this instead be package-protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
