phet commented on code in PR #3840:
URL: https://github.com/apache/gobblin/pull/3840#discussion_r1412677033
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerMetrics.java:
##########
@@ -76,8 +76,9 @@ public class DagManagerMetrics {
private final Map<String, ContextAwareMeter> executorSlaExceededMeters =
Maps.newConcurrentMap();
private final Map<String, ContextAwareMeter> executorJobSentMeters =
Maps.newConcurrentMap();
- // Metrics for unexpected flow handling failures
+ // Metric for unexpected flow handling failures
private ContextAwareCounter failedLaunchEventsOnActivationCount;
+ private ContextAwareCounter successfulLaunchEventsOnActivationCount;
Review Comment:
now these are for flow handling **outcomes** (although only for startup, so
not in the general sense)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
