phet commented on code in PR #3840:
URL: https://github.com/apache/gobblin/pull/3840#discussion_r1412678292
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerMetrics.java:
##########
@@ -212,6 +216,13 @@ public void incrementFailedLaunchCount() {
}
}
+ // Increment the count for num of successful launches attempted during
leader activation
+ public void incrementSuccessfulLaunchAttemptCount() {
Review Comment:
I see the comment above (that arguably should be javadoc), but the method
name invites confusion, since it sounds like this is for counting successes,
irrespective of whether or not during startup
(BTW, "system startup" is slightly more accurate for our multi-leader arch
than is "leader activation" )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
