[
https://issues.apache.org/jira/browse/GOBBLIN-1973?focusedWorklogId=895292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895292
]
ASF GitHub Bot logged work on GOBBLIN-1973:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/23 22:05
Start Date: 12/Dec/23 22:05
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3845:
URL: https://github.com/apache/gobblin/pull/3845
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1973
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
When Manifest distcp fails to set permissions for any reason, we would
expect a retry of the copy to allow the datasets to reach eventual consistency.
However, the current logic of checking if a file is eligible for copy is to
check if the source file is newer, if so copy, and if the source file is
exactly the same modification time as the destination file, also copy if the
permissions are different. However, in most cases the destination will have a
newer modification time once it is written and set permissions, so the source
file will generally be older but we still want the permissions to match.
This PR changes the check so that if the source file is older, we still want
to check permissions between source and destination to ensure if the file is
eligible for copy.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 895292)
Remaining Estimate: 0h
Time Spent: 10m
> Manifest file copy ignores copying files when source file permissions differ
> from dest
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1973
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1973
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When Manifest distcp fails to set permissions for any reason, we would expect
> a retry of the copy to allow the datasets to reach eventual consistency.
> However, the current logic of checking if a file is eligible for copy is to
> check if the source file is newer, if so copy, and if the source file is
> exactly the same modification time as the destination file, also copy if the
> permissions are different. However, in most cases the destination will have a
> newer modification time once it is written and set permissions, so the source
> file will generally be older but we still want the permissions to match.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
