[
https://issues.apache.org/jira/browse/GOBBLIN-1973?focusedWorklogId=895293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895293
]
ASF GitHub Bot logged work on GOBBLIN-1973:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/23 22:17
Start Date: 12/Dec/23 22:17
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3845:
URL: https://github.com/apache/gobblin/pull/3845#issuecomment-1852901473
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base
[(`00c60ca`)](https://app.codecov.io/gh/apache/gobblin/commit/00c60ca6492644652c66905eb384ab145e348bbf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
42.61% compared to head
[(`91c3560`)](https://app.codecov.io/gh/apache/gobblin/pull/3845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
46.09%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3845 +/- ##
============================================
+ Coverage 42.61% 46.09% +3.47%
+ Complexity 3779 2182 -1597
============================================
Files 804 416 -388
Lines 33940 17992 -15948
Branches 3769 2194 -1575
============================================
- Hits 14463 8293 -6170
+ Misses 18103 8815 -9288
+ Partials 1374 884 -490
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3845?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 895293)
Time Spent: 20m (was: 10m)
> Manifest file copy ignores copying files when source file permissions differ
> from dest
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1973
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1973
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When Manifest distcp fails to set permissions for any reason, we would expect
> a retry of the copy to allow the datasets to reach eventual consistency.
> However, the current logic of checking if a file is eligible for copy is to
> check if the source file is newer, if so copy, and if the source file is
> exactly the same modification time as the destination file, also copy if the
> permissions are different. However, in most cases the destination will have a
> newer modification time once it is written and set permissions, so the source
> file will generally be older but we still want the permissions to match.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
