[
https://issues.apache.org/jira/browse/GOBBLIN-1977?focusedWorklogId=895889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895889
]
ASF GitHub Bot logged work on GOBBLIN-1977:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/23 18:07
Start Date: 15/Dec/23 18:07
Worklog Time Spent: 10m
Work Description: phet opened a new pull request, #3849:
URL: https://github.com/apache/gobblin/pull/3849
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1977
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
The `PasswordManager` silently continues on when the configured master
password key path does not exist in the FS. this makes debugging exceptionally
difficult. Instead, it should log such a warning, upon finding that situation.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
existing tests, as this change concerns logging only
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 895889)
Remaining Estimate: 0h
Time Spent: 10m
> `PasswordManager` should log when configured master password file does not
> exist
> --------------------------------------------------------------------------------
>
> Key: GOBBLIN-1977
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1977
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Despite not changing our job's properties, we found it failing to connect to
> the DB:
> {code}
> 2023-12-07 11:21:41 PST INFO [TaskStateModelFactory-task_thread-0]
> com.zaxxer.hikari.HikariDataSource -
> HikariPool-1-MysqlStateStore-redacted_db_name - Starting...
> 2023-12-07 11:21:42 PST ERROR [TaskStateModelFactory-task_thread-0]
> com.zaxxer.hikari.pool.HikariPool -
> HikariPool-1-MysqlStateStore-redacted_db_name - Exception during pool
> initialization.
> java.sql.SQLException: Access denied for user 'redacted_db_name'@'10.1.2.3'
> (using password: YES)
> at
> com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
> at
> com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
> ...
> {code}
> on previously successful runs, logging showed:
> {code}
> 2023-12-07 15:24:55 PST INFO [TaskStateModelFactory-task_thread-0]
> com.zaxxer.hikari.HikariDataSource -
> HikariPool-1-MysqlStateStore-redacted_db_name - Starting...
> 2023-12-07 15:24:56 PST INFO [TaskStateModelFactory-task_thread-0]
> com.zaxxer.hikari.HikariDataSource -
> HikariPool-1-MysqlStateStore-redacted_db_name - Start completed.
> ...
> {code}
> throughout we were supplied our DB password as:
> {code}
> state.store.db.password=ENC(rEdActeD=)
> ...
> encrypt.key.loc=/path/to/master/key
> ...
> {code}
> the issue wound up being that the master password path was removed from the
> FS. this would have been significantly easier to diagnose if the
> `PasswordManager` had logged this discovery upon detection, rather than
> silently skipping the configured path, after finding the file not to exist.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
