[
https://issues.apache.org/jira/browse/GOBBLIN-1977?focusedWorklogId=895890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895890
]
ASF GitHub Bot logged work on GOBBLIN-1977:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/23 18:09
Start Date: 15/Dec/23 18:09
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3849:
URL: https://github.com/apache/gobblin/pull/3849#discussion_r1428322518
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -720,6 +720,8 @@ private void cancelDagNode(DagNode<JobExecutionPlan>
dagNodeToCancel) throws Exe
String serializedFuture =
DagManagerUtils.getSpecProducer(dagNodeToCancel).serializeAddSpecResponse(future);
props.put(ConfigurationKeys.SPEC_PRODUCER_SERIALIZED_FUTURE,
serializedFuture);
sendCancellationEvent(dagNodeToCancel.getValue());
+ } else {
+ log.warn("No Job future when canceling DAG node (hence, not sending
cancellation event) - {}", dagNodeToCancel.getValue().getJobSpec().getUri());
Review Comment:
not strictly related... just sprinkling in better logging concerning a
question I was recently pondering during another investigation
Issue Time Tracking
-------------------
Worklog Id: (was: 895890)
Time Spent: 20m (was: 10m)
> `PasswordManager` should log when configured master password file does not
> exist
> --------------------------------------------------------------------------------
>
> Key: GOBBLIN-1977
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1977
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Despite not changing our job's properties, we found it failing to connect to
> the DB:
> {code}
> 2023-12-07 11:21:41 PST INFO [TaskStateModelFactory-task_thread-0]
> com.zaxxer.hikari.HikariDataSource -
> HikariPool-1-MysqlStateStore-redacted_db_name - Starting...
> 2023-12-07 11:21:42 PST ERROR [TaskStateModelFactory-task_thread-0]
> com.zaxxer.hikari.pool.HikariPool -
> HikariPool-1-MysqlStateStore-redacted_db_name - Exception during pool
> initialization.
> java.sql.SQLException: Access denied for user 'redacted_db_name'@'10.1.2.3'
> (using password: YES)
> at
> com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
> at
> com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
> ...
> {code}
> on previously successful runs, logging showed:
> {code}
> 2023-12-07 15:24:55 PST INFO [TaskStateModelFactory-task_thread-0]
> com.zaxxer.hikari.HikariDataSource -
> HikariPool-1-MysqlStateStore-redacted_db_name - Starting...
> 2023-12-07 15:24:56 PST INFO [TaskStateModelFactory-task_thread-0]
> com.zaxxer.hikari.HikariDataSource -
> HikariPool-1-MysqlStateStore-redacted_db_name - Start completed.
> ...
> {code}
> throughout we were supplied our DB password as:
> {code}
> state.store.db.password=ENC(rEdActeD=)
> ...
> encrypt.key.loc=/path/to/master/key
> ...
> {code}
> the issue wound up being that the master password path was removed from the
> FS. this would have been significantly easier to diagnose if the
> `PasswordManager` had logged this discovery upon detection, rather than
> silently skipping the configured path, after finding the file not to exist.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
