Will-Lo commented on code in PR #3854:
URL: https://github.com/apache/gobblin/pull/3854#discussion_r1446779169
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -95,6 +95,7 @@ public Optional<Dag<JobExecutionPlan>>
createExecutionPlanIfValid(FlowSpec flowS
}
addFlowExecutionIdIfAbsent(flowMetadata, optionalFlowExecutionId,
jobExecutionPlanDagOptional.get());
+ // TODO: emit flow compilation metric
Review Comment:
the line below already emits a metric, unless you mean like a count?
##########
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiterTest.java:
##########
@@ -309,7 +309,7 @@ public void testReminderEventAcquireLeaseOnCompletedLease()
throws IOException,
Thread.sleep(MORE_THAN_EPSILON);
// Now have a reminder event check-in on the completed lease
LeaseAttemptStatus attemptStatus =
- mysqlMultiActiveLeaseArbiter.tryAcquireLease(resumeDagAction,
selectInfoResult.getEventTimeMillis(), true);
+ mysqlMultiActiveLeaseArbiter.tryAcquireLease(resumeDagAction,
selectInfoResult.getEventTimeMillis(), true, false);
Review Comment:
Probably want to add one test where the the replacement boolean is set to
true and validate that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
