phet commented on code in PR #3854:
URL: https://github.com/apache/gobblin/pull/3854#discussion_r1446810702
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MultiActiveLeaseArbiter.java:
##########
@@ -53,10 +53,14 @@ public interface MultiActiveLeaseArbiter {
* @param flowAction uniquely identifies the flow and the present action
upon it
* @param eventTimeMillis is the time this flow action was triggered
* @param isReminderEvent true if the flow action event we're checking on is
a reminder event
+ * @param skipFlowExecutionIdReplacement if true then does not replace the
flowExecutionId in the flowAction returned
Review Comment:
naming "skip... replacement" seems indirect. better might be to reverse the
sense and call it `replaceFlowExecId`. even better might be
`adoptConsensusFlowExecutionId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
