phet commented on code in PR #3855: URL: https://github.com/apache/gobblin/pull/3855#discussion_r1448183753
########## gobblin-core-base/src/main/java/org/apache/gobblin/instrumented/Instrumented.java: ########## @@ -41,6 +39,8 @@ import com.google.common.collect.Lists; import com.google.common.io.Closer; +import javax.annotation.Nonnull; Review Comment: when I see: > Import order: java, org, com, gobblin. here - https://gobblin.apache.org/docs/developer-guide/CodingStyle/ I had always presume `javax` would go next to `java`, not between `com` and `gobblin`. are you sure this is supposed to move here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
