arjun4084346 commented on code in PR #3855:
URL: https://github.com/apache/gobblin/pull/3855#discussion_r1449429719


##########
gobblin-core-base/src/main/java/org/apache/gobblin/instrumented/Instrumented.java:
##########
@@ -255,6 +259,10 @@ public static void markMeter(Optional<Meter> meter) {
     markMeter(meter, 1);
   }
 
+  public static void markMeter(Meter meter) {

Review Comment:
   There are many non-gaas callers to this method with Optional parameter, 
which may be providing parameter that is truly optional.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to