Will-Lo commented on code in PR #3857:
URL: https://github.com/apache/gobblin/pull/3857#discussion_r1449579783


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -122,7 +119,7 @@ public Optional<Dag<JobExecutionPlan>> 
validateAndHandleConcurrentExecution(Conf
       sharedFlowMetricsSingleton.conditionallyUpdateFlowGaugeSpecState(spec,
           SharedFlowMetricsSingleton.CompiledState.SKIPPED);
       
Instrumented.markMeter(sharedFlowMetricsSingleton.getSkippedFlowsMeter());
-      if (!isScheduledFlow((FlowSpec) spec)) {
+      if (!((FlowSpec) spec).isScheduled()) {

Review Comment:
   Is there a scenario where `spec` isn't a flowspec here? Maybe it makes sense 
for the function to require a flowspec so we don't need to keep casting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to