phet commented on code in PR #3857:
URL: https://github.com/apache/gobblin/pull/3857#discussion_r1450112803


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -104,35 +100,35 @@ public Optional<Dag<JobExecutionPlan>> 
createExecutionPlanIfValid(FlowSpec flowS
   /**
    * Checks if flowSpec disallows concurrent executions, and if so then checks 
if another instance of the flow is
    * already running and emits a FLOW FAILED event. Otherwise, this check 
passes.
-   * @return Optional<Dag<JobExecutionPlan>> if caller allowed to execute flow 
and compile spec, else absent Optional
+   * @return Optional<Dag<JobExecutionPlan>> if caller allowed to execute flow 
and compile flowSpec, else absent Optional

Review Comment:
   nit: "absent Optional" => `Optional.absent()`



##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -276,8 +277,12 @@ protected void 
submitFlowToDagManagerHelper(DagActionStore.DagAction dagAction,
     try {
       URI flowUri = FlowSpec.Utils.createFlowSpecUri(flowId);
       spec = (FlowSpec) flowCatalog.getSpecs(flowUri);

Review Comment:
   should `FlowCatalog.getSpecs` override w/ a covariant return type?
   
   i.e. the `FlowSpec` in:
   ```
     @Override
     public FlowSpec getSpecs(URI uri) throws SpecNotFoundException {
   ```
   



##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpec.java:
##########
@@ -125,6 +128,19 @@ public static FlowSpec.Builder builder(URI catalogURI, 
Properties flowProps) {
     }
   }
 
+  /**
+   * Add property to Config (also propagated to the Properties field)
+   * @param key
+   * @param value
+   */
+  public void addProperty(String key, String value) {

Review Comment:
   since this modifies two fields, instances now require synchronization around 
all access of either field



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to