arjun4084346 commented on code in PR #3857:
URL: https://github.com/apache/gobblin/pull/3857#discussion_r1450967280


##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpec.java:
##########
@@ -125,6 +128,19 @@ public static FlowSpec.Builder builder(URI catalogURI, 
Properties flowProps) {
     }
   }
 
+  /**
+   * Add property to Config (also propagated to the Properties field)
+   * @param key
+   * @param value
+   */
+  public void addProperty(String key, String value) {

Review Comment:
   suggested to set `configAsProperties` and  `config` as `private` and 
`volatile` , so one should always be forced to use this method to update them 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to