umustafi commented on code in PR #3857:
URL: https://github.com/apache/gobblin/pull/3857#discussion_r1450968798


##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpec.java:
##########
@@ -125,6 +128,19 @@ public static FlowSpec.Builder builder(URI catalogURI, 
Properties flowProps) {
     }
   }
 
+  /**
+   * Add property to Config (also propagated to the Properties field)
+   * @param key
+   * @param value
+   */
+  public void addProperty(String key, String value) {

Review Comment:
   I updated the fields to be private so they are only updated through the 
addProperty method and bc we don't expect this scenario to occur I don't want 
to over complicate with rw lock for now. Future developers should be able to 
quickly notice this with the volatile keyword and documentation. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to