[ 
https://issues.apache.org/jira/browse/GOBBLIN-1987?focusedWorklogId=900208&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900208
 ]

ASF GitHub Bot logged work on GOBBLIN-1987:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jan/24 19:07
            Start Date: 17/Jan/24 19:07
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3861:
URL: https://github.com/apache/gobblin/pull/3861#discussion_r1456336521


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -615,6 +615,8 @@ public AddSpecResponse onAddSpec(Spec addedSpec) {
       }
       if (PropertiesUtils.getPropAsBoolean(jobConfig, 
ConfigurationKeys.FLOW_RUN_IMMEDIATELY, "false")) {
         _log.info("RunImmediately requested, hence executing FlowSpec: " + 
addedSpec);
+        // Use 0 for trigger event time of a run-immediately flow
+        
jobConfig.setProperty(ConfigurationKeys.ORCHESTRATOR_TRIGGER_EVENT_TIME_MILLIS_KEY,
 "0");

Review Comment:
   Is there a scenario where we don't set this key? Wouldn't it be better to 
handle this on the reader side e.g. the `orchestrator` class?
   I see this snippet:
   ```
             _log.warn("Skipping execution of spec: {} because missing trigger 
timestamp in job properties",
                 jobProps.getProperty(ConfigurationKeys.JOB_NAME_KEY));
             flowMetadata.put(TimingEvent.METADATA_MESSAGE, "Flow orchestration 
skipped because no trigger timestamp "
                 + "associated with flow action.");
             if (this.eventSubmitter.isPresent()) {
               new TimingEvent(this.eventSubmitter.get(), 
TimingEvent.FlowTimings.FLOW_FAILED).stop(flowMetadata);
             }
             return;
           }
    ```





Issue Time Tracking
-------------------

    Worklog Id:     (was: 900208)
    Time Spent: 20m  (was: 10m)

> Fix skipped run-immediately flows in multi-active scheduler mode
> ----------------------------------------------------------------
>
>                 Key: GOBBLIN-1987
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1987
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Run-immediate flows are missing an event trigger timestamp and being skipped 
> in multi-active mode orchestration step. Code 
> https://github.com/apache/gobblin/blob/913d580fe19e7a6adc60d3294bac44e5a32d7bba/gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java#L241
> {{Skipping execution of spec: .... because missing trigger timestamp in job 
> properties}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to