[ 
https://issues.apache.org/jira/browse/GOBBLIN-1987?focusedWorklogId=900214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900214
 ]

ASF GitHub Bot logged work on GOBBLIN-1987:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jan/24 19:34
            Start Date: 17/Jan/24 19:34
    Worklog Time Spent: 10m 
      Work Description: umustafi commented on code in PR #3861:
URL: https://github.com/apache/gobblin/pull/3861#discussion_r1456375368


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -615,6 +615,8 @@ public AddSpecResponse onAddSpec(Spec addedSpec) {
       }
       if (PropertiesUtils.getPropAsBoolean(jobConfig, 
ConfigurationKeys.FLOW_RUN_IMMEDIATELY, "false")) {
         _log.info("RunImmediately requested, hence executing FlowSpec: " + 
addedSpec);
+        // Use 0 for trigger event time of a run-immediately flow
+        
jobConfig.setProperty(ConfigurationKeys.ORCHESTRATOR_TRIGGER_EVENT_TIME_MILLIS_KEY,
 "0");

Review Comment:
   Good point, I don't envision a scenario we would rather skip flows rather 
then use the default trigger timestamp of 0 and execute them. Removed this 
check and updated the PR





Issue Time Tracking
-------------------

    Worklog Id:     (was: 900214)
    Time Spent: 0.5h  (was: 20m)

> Fix skipped run-immediately flows in multi-active scheduler mode
> ----------------------------------------------------------------
>
>                 Key: GOBBLIN-1987
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1987
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Run-immediate flows are missing an event trigger timestamp and being skipped 
> in multi-active mode orchestration step. Code 
> https://github.com/apache/gobblin/blob/913d580fe19e7a6adc60d3294bac44e5a32d7bba/gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java#L241
> {{Skipping execution of spec: .... because missing trigger timestamp in job 
> properties}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to