[ 
https://issues.apache.org/jira/browse/GOBBLIN-1988?focusedWorklogId=900237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900237
 ]

ASF GitHub Bot logged work on GOBBLIN-1988:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jan/24 21:20
            Start Date: 17/Jan/24 21:20
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 opened a new pull request, #3862:
URL: https://github.com/apache/gobblin/pull/3862

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1988
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   Now when the OOM error happens, we just log out the error and keep the 
container running there without doing anything. In this case we should fail the 
container and retry the task.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   Mock the OOM error and verified that before the change, task just hang 
there, and after the change, task got failed and retried as expected
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 900237)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fail the streaming container when OOM issue happens
> ---------------------------------------------------
>
>                 Key: GOBBLIN-1988
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1988
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Now when the OOM error happens, we just log out the error and keep the 
> container running there without doing anything. In this case we should fail 
> the container and retry the task. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to