[ 
https://issues.apache.org/jira/browse/GOBBLIN-1988?focusedWorklogId=900542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900542
 ]

ASF GitHub Bot logged work on GOBBLIN-1988:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Jan/24 01:07
            Start Date: 19/Jan/24 01:07
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 commented on code in PR #3862:
URL: https://github.com/apache/gobblin/pull/3862#discussion_r1458164630


##########
gobblin-utility/src/main/java/org/apache/gobblin/util/LoggingUncaughtExceptionHandler.java:
##########
@@ -42,6 +45,7 @@ public LoggingUncaughtExceptionHandler(Optional<Logger> 
logger) {
 
   @Override
   public void uncaughtException(Thread t, Throwable e) {
+    exception = e;

Review Comment:
   it's being used in get method for the main thread to determine whether there 
is an exception in this thread: 
https://github.com/apache/gobblin/pull/3862/files#diff-5486722712e94a92c9e9129f7b3768c87cd7c3f3cf08613c24b9a5fd4131e6ebR163





Issue Time Tracking
-------------------

    Worklog Id:     (was: 900542)
    Time Spent: 40m  (was: 0.5h)

> Fail the streaming container when OOM issue happens
> ---------------------------------------------------
>
>                 Key: GOBBLIN-1988
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1988
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Now when the OOM error happens, we just log out the error and keep the 
> container running there without doing anything. In this case we should fail 
> the container and retry the task. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to