arjun4084346 commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1462554255
##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -359,40 +364,57 @@ public void testRunQuotaExceeds() throws Exception {
try {
this.flowConfigClient.createFlowConfig(flowConfig2);
} catch (RestLiResponseException e) {
+ /* Note: this exception may NOT occur if the first job above is
processed immediately so TEST_FLOW_ID2 will remain
Review Comment:
I think, if this call does not always create RestLiResponseException, we
should not have this unit test at all.
Or we can simulate the job the first job to run longer.
and +1 to the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]