umustafi commented on code in PR #3864:
URL: https://github.com/apache/gobblin/pull/3864#discussion_r1462573450


##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -328,23 +328,28 @@ public void testUncompilableJob() throws Exception {
     
Assert.assertFalse(this.gobblinServiceManager.getScheduler().getScheduledFlowSpecs().containsKey(uri.toString()));
   }
 
-  @Test (dependsOnMethods = "testUncompilableJob")
+  // Disabled because of timing issue with scheduler
+  @Test (dependsOnMethods = "testUncompilableJob", enabled = false, groups = 
{"disabledOnCI"})
   public void testRunOnceJob() throws Exception {
     FlowConfig flowConfig = new FlowConfig().setId(TEST_FLOW_ID)
         .setTemplateUris(TEST_TEMPLATE_URI).setProperties(new 
StringMap(flowProperties));
 
     this.flowConfigClient.createFlowConfig(flowConfig);
 
     // runOnce job is deleted soon after it is orchestrated
-    
AssertWithBackoff.create().maxSleepMs(200L).timeoutMs(2000L).backoffFactor(1)
+    
AssertWithBackoff.create().maxSleepMs(200L).timeoutMs(60000L).backoffFactor(1)
         .assertTrue(input -> 
this.gobblinServiceManager.getFlowCatalog().getSpecs().size() == 0,
           "Waiting for job to get orchestrated...");
-    
AssertWithBackoff.create().maxSleepMs(100L).timeoutMs(1000L).backoffFactor(1)
+    
AssertWithBackoff.create().maxSleepMs(100L).timeoutMs(2000L).backoffFactor(1)
           .assertTrue(input -> 
!this.gobblinServiceManager.getScheduler().getScheduledFlowSpecs().containsKey(TEST_URI.toString()),
               "Waiting for job to get orchestrated...");
+    
AssertWithBackoff.create().maxSleepMs(200L).timeoutMs(2000L).backoffFactor(1)
+        .assertTrue(input -> 
!this.gobblinServiceManager.getScheduler().getLastUpdatedTimeForFlowSpec().containsKey(TEST_URI.toString()),
+            "Waiting for job to get orchestrated...");
   }
 
-  @Test (dependsOnMethods = "testRunOnceJob")
+  // Disabled because whether the test will raise the 503 exception is timing 
dependent

Review Comment:
   I tried using AssertWithBackoff but it ends up being cleaned _too_ quickly 
is the issue I believe



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to