[ 
https://issues.apache.org/jira/browse/GOBBLIN-1991?focusedWorklogId=901597&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901597
 ]

ASF GitHub Bot logged work on GOBBLIN-1991:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Jan/24 04:47
            Start Date: 25/Jan/24 04:47
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3867:
URL: https://github.com/apache/gobblin/pull/3867#discussion_r1465836473


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopyConfiguration.java:
##########
@@ -120,11 +120,8 @@ public CopyConfigurationBuilder(FileSystem targetFs, 
Properties properties) {
           properties.containsKey(DESTINATION_GROUP_KEY) ? 
Optional.of(properties.getProperty(DESTINATION_GROUP_KEY))
               : Optional.<String>absent();
       this.preserve = 
PreserveAttributes.fromMnemonicString(properties.getProperty(PRESERVE_ATTRIBUTES_KEY));
-      Path publishDirTmp = new 
Path(properties.getProperty(ConfigurationKeys.DATA_PUBLISHER_FINAL_DIR));
-      if (!publishDirTmp.isAbsolute()) {
-        publishDirTmp = new Path(targetFs.getWorkingDirectory(), 
publishDirTmp);
-      }
-      this.publishDir = publishDirTmp;
+
+      this.publishDir = calculatePublishDir(targetFs, properties);

Review Comment:
   this is just refactoring to de-duplicate code





Issue Time Tracking
-------------------

            Worklog Id:     (was: 901597)
    Remaining Estimate: 0h
            Time Spent: 10m

> RecursiveCopyableDataset is not setting target dataset root correctly
> ---------------------------------------------------------------------
>
>                 Key: GOBBLIN-1991
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1991
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to