[ 
https://issues.apache.org/jira/browse/GOBBLIN-1991?focusedWorklogId=901780&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901780
 ]

ASF GitHub Bot logged work on GOBBLIN-1991:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Jan/24 18:58
            Start Date: 25/Jan/24 18:58
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3867:
URL: https://github.com/apache/gobblin/pull/3867#discussion_r1466800894


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/RecursiveCopyableDataset.java:
##########
@@ -239,7 +237,14 @@ private static boolean sameFile(FileStatus fileInSource, 
FileStatus fileInTarget
   }
 
   @Override
+  // this is more like a getTargetDatasetPath
+  // this should preferably be called after the call to getCopyableFiles() 
because

Review Comment:
   seems like this comment isn't completed?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 901780)
    Time Spent: 20m  (was: 10m)

> RecursiveCopyableDataset is not setting target dataset root correctly
> ---------------------------------------------------------------------
>
>                 Key: GOBBLIN-1991
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1991
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to