[
https://issues.apache.org/jira/browse/GOBBLIN-1992?focusedWorklogId=902039&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902039
]
ASF GitHub Bot logged work on GOBBLIN-1992:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/24 23:27
Start Date: 26/Jan/24 23:27
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3868:
URL: https://github.com/apache/gobblin/pull/3868#discussion_r1468234972
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/MDCContextPropagator.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.temporal.ddm.work.assistance;
+
+import com.google.protobuf.ByteString;
+import io.temporal.api.common.v1.Payload;
+import io.temporal.common.context.ContextPropagator;
+import java.nio.charset.StandardCharsets;
+import java.util.HashMap;
+import java.util.Map;
+import lombok.extern.slf4j.Slf4j;
+import org.slf4j.MDC;
+
+
+/**
+ * Context propagator for MDC in Temporal GaaS flows, which is used to share
context between workflows and activities.
+ * Keys added to MDC will show up in Temporal headers serialized as protobufs
Review Comment:
https://api-docs.temporal.io/#temporal.api.common.v1.Header
They're part of metadata that gets passed between workflows and activities.
The ContextPropagators and Interceptors can read from these headers. When you
search up workflows in the server side UI you can inspect this metadata
(although they're serialized)
Issue Time Tracking
-------------------
Worklog Id: (was: 902039)
Time Spent: 40m (was: 0.5h)
> Allow per job level logging in Gobblin Temporal workflows
> ---------------------------------------------------------
>
> Key: GOBBLIN-1992
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1992
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the Temporal job context does not include the job metadata e.g.
> flow name, flow group, flow execution ID, which is critical for debugging
> workflows in the temporal cluster.
> We want to have per job logging so that it is easier to debug multiple
> Gobblin workflows on Temporal sent through GaaS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)