[ 
https://issues.apache.org/jira/browse/GOBBLIN-1992?focusedWorklogId=902040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902040
 ]

ASF GitHub Bot logged work on GOBBLIN-1992:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jan/24 23:30
            Start Date: 26/Jan/24 23:30
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3868:
URL: https://github.com/apache/gobblin/pull/3868#discussion_r1468236220


##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ProcessWorkUnitsJobLauncher.java:
##########
@@ -93,4 +97,11 @@ public void submitJob(List<WorkUnit> workunits) {
       throw new RuntimeException(e);
     }
   }
+
+  private void setupMDCFromJobState(JobState jobState) {
+    // TODO: log4j2 has better syntax around conditional logging such that the 
key does not need to be included in the value

Review Comment:
   Yeah this is a good point, it might make it harder to set up queries on logs 
though if we keep the keys in the values. I'll change the keys to match what 
the API accepts and format the logs appropriately.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 902040)
    Time Spent: 50m  (was: 40m)

> Allow per job level logging in Gobblin Temporal workflows
> ---------------------------------------------------------
>
>                 Key: GOBBLIN-1992
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1992
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Currently the Temporal job context does not include the job metadata e.g. 
> flow name, flow group, flow execution ID, which is critical for debugging 
> workflows in the temporal cluster.
> We want to have per job logging so that it is easier to debug multiple 
> Gobblin workflows on Temporal sent through GaaS.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to