[
https://issues.apache.org/jira/browse/GOBBLIN-1997?focusedWorklogId=902745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902745
]
ASF GitHub Bot logged work on GOBBLIN-1997:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/24 19:07
Start Date: 30/Jan/24 19:07
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3872:
URL: https://github.com/apache/gobblin/pull/3872#issuecomment-1917708731
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3872?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: `4 lines` in your changes are missing coverage. Please review.
> Comparison is base
[(`389c158`)](https://app.codecov.io/gh/apache/gobblin/commit/389c15851248fecfb13b737ea1ddde31800896d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
47.71% compared to head
[(`ff3c015`)](https://app.codecov.io/gh/apache/gobblin/pull/3872?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
50.42%.
> Report is 3 commits behind head on master.
> :exclamation: Current head ff3c015 differs from pull request most recent
head 272ac5d. Consider uploading reports for the commit 272ac5d to get more
accurate results
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3872?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...n/data/management/copy/iceberg/IcebergDataset.java](https://app.codecov.io/gh/apache/gobblin/pull/3872?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaWNlYmVyZy9JY2ViZXJnRGF0YXNldC5qYXZh)
| 83.33% | [1 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3872?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[.../management/copy/iceberg/IcebergDatasetFinder.java](https://app.codecov.io/gh/apache/gobblin/pull/3872?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaWNlYmVyZy9JY2ViZXJnRGF0YXNldEZpbmRlci5qYXZh)
| 0.00% | [2 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3872?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3872 +/- ##
============================================
+ Coverage 47.71% 50.42% +2.70%
+ Complexity 11109 5920 -5189
============================================
Files 2160 1072 -1088
Lines 85513 41203 -44310
Branches 9478 4625 -4853
============================================
- Hits 40805 20775 -20030
+ Misses 41030 18624 -22406
+ Partials 3678 1804 -1874
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3872?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 902745)
Time Spent: 40m (was: 0.5h)
> Avoid deleting flowSpec too early
> ----------------------------------
>
> Key: GOBBLIN-1997
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1997
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> [https://github.com/apache/gobblin/blob/67c610117c2b757bb15714826e0b0edc3e6b26a5/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java#L290]
>
> If a non-active host receives and processes the LAUNCH event before the
> leader does, then we encounter a SpecNotFoundException when the leader goes
> to process the event and the execution of the LAUNCH will be missed. This PR
> moves the deletion to the DagManager and does it only after completing addDag
> to persist the event and after checking active status.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
