[
https://issues.apache.org/jira/browse/GOBBLIN-1996?focusedWorklogId=902830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902830
]
ASF GitHub Bot logged work on GOBBLIN-1996:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/24 15:38
Start Date: 31/Jan/24 15:38
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1473039705
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/app/ServiceBasedAppLauncher.java:
##########
@@ -163,9 +170,17 @@ public void run() {
});
LOG.info("Starting the Gobblin application and all its associated
Services");
+ for (Service service : this.services) {
+ LOG.info("Starting service " + service.getClass().getSimpleName());
+ }
// Start the application
- this.serviceManager.startAsync().awaitHealthy();
+ try {
+
this.serviceManager.startAsync().awaitHealthy(startupTimeout.getSeconds(),
TimeUnit.SECONDS);
Review Comment:
One of the services, the FSConfigurationManager, has some main thread
interrupting behavior that causes the start call to last indefinitely.
This prevents users from being able to call the shutdown method because this
method is synchronized. I'm adding a configuration for the timeout to be
configurable, with the default being indefinitely waiting
Issue Time Tracking
-------------------
Worklog Id: (was: 902830)
Remaining Estimate: 0h
Time Spent: 10m
> Add ability for Yarn app to terminate on finishing of temporal flow
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1996
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1996
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
