[
https://issues.apache.org/jira/browse/GOBBLIN-2001?focusedWorklogId=904484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904484
]
ASF GitHub Bot logged work on GOBBLIN-2001:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/24 00:17
Start Date: 10/Feb/24 00:17
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3877:
URL: https://github.com/apache/gobblin/pull/3877
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2001
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Currently in the Gobblin framework all failed tasks will emit events when
they fail and include some stacktrace to provide context on the failure. This
is problematic when there are Gobblin jobs with hundreds of thousands of tasks
(e.g. iceberg distcp) and causes Kafka partitions to lag under the larger
events.
We want to enable a config to disable this, and potentially extend this
solution to disable all task level events as they can get quite noisy and logs
generally provide better context.
This PR disables emitting failed events if
`gobblin.task.disable.failed.events` is set to true (defaults to false so no
change)
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 904484)
Remaining Estimate: 0h
Time Spent: 10m
> Add config to disable emission of failed task events
> ----------------------------------------------------
>
> Key: GOBBLIN-2001
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2001
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently in the Gobblin framework all failed tasks will emit events when
> they fail and include some stacktrace to provide context on the failure. This
> is problematic when there are Gobblin jobs with hundreds of thousands of
> tasks (e.g. iceberg distcp) and causes Kafka partitions to lag under the
> larger events.
> We want to enable a config to disable this, and potentially extend this
> solution to disable all task level events as they can get quite noisy and
> logs generally provide better context.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)