[ 
https://issues.apache.org/jira/browse/GOBBLIN-2001?focusedWorklogId=904628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904628
 ]

ASF GitHub Bot logged work on GOBBLIN-2001:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Feb/24 17:55
            Start Date: 12/Feb/24 17:55
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3877:
URL: https://github.com/apache/gobblin/pull/3877#discussion_r1486562081


##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/TaskConfigurationKeys.java:
##########
@@ -35,7 +35,11 @@ public class TaskConfigurationKeys {
   public static final String TASK_IS_SINGLE_BRANCH_SYNCHRONOUS = 
"gobblin.task.is.single.branch.synchronous";
   public static final String DEFAULT_TASK_IS_SINGLE_BRANCH_SYNCHRONOUS = 
Boolean.toString(false);
 
-
   public static final String TASK_SKIP_ERROR_RECORDS = 
"task.skip.error.records";
   public static final long DEFAULT_TASK_SKIP_ERROR_RECORDS = 0;
+
+  public static final String TASK_DISABLE_FAILED_EVENTS = 
"gobblin.task.failure.disable.event.emission";

Review Comment:
   *nit
   It should be "gobblin.task.disable.failed.event.emission" to match the 
string name





Issue Time Tracking
-------------------

    Worklog Id:     (was: 904628)
    Time Spent: 40m  (was: 0.5h)

> Add config to disable emission of failed task events
> ----------------------------------------------------
>
>                 Key: GOBBLIN-2001
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2001
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: William Lo
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently in the Gobblin framework all failed tasks will emit events when 
> they fail and include some stacktrace to provide context on the failure. This 
> is problematic when there are Gobblin jobs with hundreds of thousands of 
> tasks (e.g. iceberg distcp) and causes Kafka partitions to lag under the 
> larger events. 
> We want to enable a config to disable this, and potentially extend this 
> solution to disable all task level events as they can get quite noisy and 
> logs generally provide better context.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to