Will-Lo opened a new pull request, #3877:
URL: https://github.com/apache/gobblin/pull/3877

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-2001
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   
   Currently in the Gobblin framework all failed tasks will emit events when 
they fail and include some stacktrace to provide context on the failure. This 
is problematic when there are Gobblin jobs with hundreds of thousands of tasks 
(e.g. iceberg distcp) and causes Kafka partitions to lag under the larger 
events. 
   
   We want to enable a config to disable this, and potentially extend this 
solution to disable all task level events as they can get quite noisy and logs 
generally provide better context.
   
   This PR disables emitting failed events if 
`gobblin.task.disable.failed.events` is set to true (defaults to false so no 
change)
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to