arjun4084346 commented on code in PR #3878:
URL: https://github.com/apache/gobblin/pull/3878#discussion_r1490568214


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementStateStore.java:
##########
@@ -32,44 +33,49 @@
  * and allows add/delete and other functions.
  */
 public interface DagManagementStateStore {
-  void addDag(Dag<JobExecutionPlan> dag);
   /**
    * Persist the {@link Dag} to the backing store.
-   * This is not an actual checkpoint but more like a Write-ahead log, where 
uncommitted job will be persisted
-   * and be picked up again when leader transition happens.
+   * It is named this because it is usually called to checkpoint any changes 
in {@link Dag} or in its {@link Dag.DagNode}s.
    * @param dag The dag submitted to {@link DagManager}
    */
   void writeCheckpoint(Dag<JobExecutionPlan> dag) throws IOException;

Review Comment:
   Using this name, I wanted to emphasize on its use pattern "It is named this 
because it is usually called to checkpoint any changes in {@link Dag}"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to