arjun4084346 commented on code in PR #3878:
URL: https://github.com/apache/gobblin/pull/3878#discussion_r1492773026


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlDagStateStore.java:
##########
@@ -160,21 +165,21 @@ public Set<String> getDagIds() throws IOException {
    * Convert a state store entry into a dag ID
    * e.g. storeName = group1_name1, tableName = 1234 gives dagId 
group1_name1_1234
    */
-  private String entryToDagId(String storeName, String tableName) {
+  public static String entryToDagId(String storeName, String tableName) {
     return 
Joiner.on(ServiceConfigKeys.DAG_STORE_KEY_SEPARATION_CHARACTER).join(storeName, 
tableName);
   }
 
   /**
    * Return a storeName given a dagId. Store name is defined as 
flowGroup_flowName.
    */
-  private String getStoreNameFromDagId(String dagId) {
+  public static String getStoreNameFromDagId(String dagId) {
     return dagId.substring(0, 
dagId.lastIndexOf(ServiceConfigKeys.DAG_STORE_KEY_SEPARATION_CHARACTER));
   }
 
   /**
    * Return a tableName given a dagId. Table name is defined as the 
flowExecutionId.
    */
-  private String getTableNameFromDagId(String dagId) {
+  public static String getTableNameFromDagId(String dagId) {

Review Comment:
   yea they can remain private



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to